Feature/SE integration #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> # Conflicts: # src/modules/module.hpp
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
# Conflicts: # src/loaders/loader.hpp
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
# Conflicts: # src/se/impl/common.hpp
iceseer
force-pushed
the
feature/se
branch
2 times, most recently
from
c710fe6 to
edaa255
Compare
iceseer
force-pushed
the
feature/se
branch
2 times, most recently
from
3d0fdf7 to
0cad2a2
Compare
[remove] configurator changes
xDimon
reviewed
Jun 5, 2025
xDimon
approved these changes
Jun 5, 2025
Harrm
reviewed
Jun 6, 2025
src/se/impl/dispatcher.hpp
Outdated
|
|
||
| namespace jam::se { | ||
|
|
||
| struct IDispatcher { |
There was a problem hiding this comment.
I don't think we have a convention to prefix interfaces with "I"?
Harrm
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.